libplayer

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

libplayer

Paul Osmialowski
Hi Brian,

I don't know if it's not too late to suggest things. It would be great
to split new Player into two parts: libplayer with all functions except
main() and main program with main() function only. I guess, that would
be great step to make possible building Stage on environments like
Cygwin in near future.

Also I have noticed, that Player-1.6.5 does not contain important Ben
Grocholsky's v4lcapture.c patch released for Player-1.6.4. There is
missing munmap call on closing camera device - the reason of memleak
that made impossible to run Player 24/7 hours. I don't know where I get
this patch from, but I can't find it on patch list! It is simple and
works with both 1.6.4 and 1.6.5 versions:

--- v4lcapture.c.orig   2005-06-03 23:21:24.000000000 -0400
+++ v4lcapture.c        2005-06-03 23:06:04.000000000 -0400
@@ -184,6 +184,7 @@

  void fg_close(FRAMEGRABBER* fg)
  {
+    munmap( fg->mb_map, fg->mbuf.size);
      close( fg->fd );

      // Make sure we free all memory (backwards!)

Also my patch [1215745] for playerv that made possible to subscribe
read-only position devices and those with no geometry wasn't applied to
1.6.5 version. It is useful in two situations: to submit joystick using
position interface (it is read-only and have no geometry; as I remember
joystick isn't the only position interface with no geometry), and to
connect to demo server (all robots are read-only). Would be great to see
it in new Player release.

If you plan to add video4linux2 support, please don't drop good old
video4linux support. There are some non-Linux POSIX systems that
provides limited video4linux compatible support for Brooktree-based PCI
cards.

Best regards,
Paul


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Playerstage-users mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/playerstage-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: libplayer

Brad Kratochvil
Hey Paul,

I'm working on the update of the camera drivers for the new 2.0
interface.  I currently have the camaerav4l driver up and working with
the c client.  Take a look (if you're brave).  You'll have to enable the
camerav4l driver at ./configure time because right now, we're not
enabling many drivers by default for development purposes.  I took a
look at the source in CVS, and it seems that the code you listed below
has already been applied.

I also wrote an application called playercam which is now included with
the player source.  This app will let you view image data and overlay
blobfinder data (with an alpha channel).  It's still a little raw, but
the version you check out from CVS should be able to use camerav4l,
cmvision, and playercam.  Any feedback is greatly appreciated.  I'll
probably get to moving the rest of the camera/blobfinder drivers over in
the next week or two.

> I don't know if it's not too late to suggest things. It would be great
> to split new Player into two parts:libplayer with all functions except
> main() and main program with main() function only.

I think Brian has gone one step further.  Player is now seperated into a
variety of core libraries.  Brian put together a list of many of the
changes at:

http://playerstage.sourceforge.net/doc/Player-cvs/player/migrate.php

That document is written more with the intention of helping developers
move drivers to the new api, but it should be helpfull in seeing what's
going on.

Best regards,

Brad

Paul Osmialowski wrote:

> Hi Brian,
>
> I don't know if it's not too late to suggest things. It would be great
> to split new Player into two parts: libplayer with all functions except
> main() and main program with main() function only. I guess, that would
> be great step to make possible building Stage on environments like
> Cygwin in near future.
>
> Also I have noticed, that Player-1.6.5 does not contain important Ben
> Grocholsky's v4lcapture.c patch released for Player-1.6.4. There is
> missing munmap call on closing camera device - the reason of memleak
> that made impossible to run Player 24/7 hours. I don't know where I get
> this patch from, but I can't find it on patch list! It is simple and
> works with both 1.6.4 and 1.6.5 versions:
>
> --- v4lcapture.c.orig   2005-06-03 23:21:24.000000000 -0400
> +++ v4lcapture.c        2005-06-03 23:06:04.000000000 -0400
> @@ -184,6 +184,7 @@
>
>  void fg_close(FRAMEGRABBER* fg)
>  {
> +    munmap( fg->mb_map, fg->mbuf.size);
>      close( fg->fd );
>
>      // Make sure we free all memory (backwards!)
>
> Also my patch [1215745] for playerv that made possible to subscribe
> read-only position devices and those with no geometry wasn't applied to
> 1.6.5 version. It is useful in two situations: to submit joystick using
> position interface (it is read-only and have no geometry; as I remember
> joystick isn't the only position interface with no geometry), and to
> connect to demo server (all robots are read-only). Would be great to see
> it in new Player release.
>
> If you plan to add video4linux2 support, please don't drop good old
> video4linux support. There are some non-Linux POSIX systems that
> provides limited video4linux compatible support for Brooktree-based PCI
> cards.
>
> Best regards,
> Paul
>
>
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & EXPO
> September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
> _______________________________________________
> Playerstage-users mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/playerstage-users


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Playerstage-users mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/playerstage-users
Loading...